dpgaspar commented on code in PR #23298:
URL: https://github.com/apache/superset/pull/23298#discussion_r1131336418
##########
superset/views/core.py:
##########
@@ -2498,7 +2503,7 @@ def fetch_datasource_metadata(self) -> FlaskResponse: #
pylint: disable=no-self
@event_logger.log_this
@expose("/queries/<float:last_updated_ms>")
@expose("/queries/<int:last_updated_ms>")
- @deprecated()
+ @deprecated(new_target="api/v1/query/updated_since")
Review Comment:
On FAB `ModelRestApi` CRUD endpoints are created given the following logic:
- All endpoints at the root of a resource name have a trailing slash,
example:
GET `/api/v1/dataset/`
POST `/api/v1/dataset/`
- All endpoints that contain a path parameter don't have a trailing slash,
example:
GET `/api/v1/dataset/1`
PUT `/api/v1/dataset/1`
On related nested resource names:
GET `/api/v1/dataset/1/column/`
GET `/api/v1/dataset/1/column/1`
This enforces a base cohesion, yet not a global cohesion. Currently on
Superset theres probably some confusion around this. I'll take a pass on the
most recent migrations, to check if there's some obvious changes ASAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
