craig-rueda commented on code in PR #23336:
URL: https://github.com/apache/superset/pull/23336#discussion_r1134205343
##########
helm/superset/templates/init-job.yaml:
##########
@@ -24,6 +24,7 @@ metadata:
"helm.sh/hook-delete-policy": "before-hook-creation"
namespace: {{ .Release.Namespace }}
spec:
+ ttlSecondsAfterFinished: 0
Review Comment:
Can you make this optional? We already have an annotation that controls the
cleanup via Helm:
```yaml
"helm.sh/hook-delete-policy": "before-hook-creation"
```
I've found it helpful to keep the completed job around after running in
order to see logs, etc. What's worse, most log aggregators like DataDog won't
scrape logs of a given container until it's been running for 30s, so if the
thing goes away immediately, logs won't be viewable.
**Suggestion:**
```yaml
# vaules.yaml
init:
ttlSecondsAfterFinished: ~
```
```
{{- if .Values.init.ttlSecondsAfterFinished }}
ttlSecondsAfterFinished: {{ .Values.init.ttlSecondsAfterFinished }}
{{- end }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
