[GitHub] [superset] kgabryje opened a new pull request, #23365: fix(chart-controls): Error if x_axis_sort and timeseries_limit_metric are included in main metrics

[via GitHub]

kgabryje opened a new pull request, #23365:
URL: https://github.com/apache/superset/pull/23365

   
   ### SUMMARY
   When user created a Echarts Bar chart and set the same "X-Axis sort by" 
(`x_axis_sort`) and "Sort by" (`timeseries_limit_metric`), and that metric was 
also used in the main metrics array, the `metrics` array in the query would 
contain duplicate metrics, which resulted in an error.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   <img width="1728" alt="image" 
src="https://user-images.githubusercontent.com/15073128/225017274-cacb10cf-0a04-40f4-ac09-35d36dc3d5a4.png";>
   
   After:
   
   <img width="1728" alt="image" 
src="https://user-images.githubusercontent.com/15073128/225016788-4d46c47f-d675-4b70-b19d-11c510f97069.png";>
   
   
   ### TESTING INSTRUCTIONS
   0. Enable GENERIC_CHART_AXES ff
   1. Create Echarts Bar chart
   2. Set Metrics, X-Axis Sort By and Sort By controls to the same metric
   3. Verify that query is successful 
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org