hughhhh commented on code in PR #23356:
URL: https://github.com/apache/superset/pull/23356#discussion_r1136090137
##########
superset/security/manager.py:
##########
@@ -1823,8 +1823,14 @@ def raise_for_access(
return
if query:
+ # if no schema is specified, use the database default; in the
future we
+ # should pass the query schema to the SQLAlchemy URI so that
it's set as
+ # the default one.
+ with database.get_sqla_engine_with_context() as engine:
Review Comment:
use get_inspector_with_context:
```suggestion
with get_inspector_with_context() as inspector:
default_schema = inspector.default_schema_name
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
