[GitHub] [superset] justinpark opened a new pull request, #23378: fix(sqllab): throw errors of commented out query

[via GitHub]

justinpark opened a new pull request, #23378:
URL: https://github.com/apache/superset/pull/23378

   ### SUMMARY
   sqllab threw an error for undefined parameters even when those parameters 
are commented out of/not used by the query. 
   This commit cleans out the commented out part from the requested query to 
fix the issue (and also reduce the payload size since commented-out parts are 
unnecessary)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   After:
   
   <img width="506" alt="Screenshot 2023-03-14 at 3 55 17 PM" 
src="https://user-images.githubusercontent.com/1392866/225164751-50645a6e-a6ca-40e4-9748-e9b5a468ba3b.png";>
   
   Before:
   <img width="495" alt="Screenshot 2023-03-14 at 3 54 23 PM" 
src="https://user-images.githubusercontent.com/1392866/225164740-559f6eaf-a918-4670-912f-784aab54e9f4.png";>
   
   
   ### TESTING INSTRUCTIONS
   Go to sqllab and then run a query including a template string within 
comment-out block like `select 123 --,{{ds}} ` 
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org