zephyring commented on code in PR #23330:
URL: https://github.com/apache/superset/pull/23330#discussion_r1137988436
##########
superset/dashboards/dao.py:
##########
@@ -41,21 +42,28 @@ class DashboardDAO(BaseDAO):
@classmethod
def get_by_id_or_slug(cls, id_or_slug: Union[int, str]) -> Dashboard:
Review Comment:
maybe a better naming could just be `get_by_identifier` but it could touches
too many files if we want to change every `id_or_slug` to `identifier`. Note
that uuid is also id in general though. So I think this naming should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
