betodealmeida commented on issue #22862: URL: https://github.com/apache/superset/issues/22862#issuecomment-1474146101
While working on an issue with schemas, I've done some foundational work for supporting catalogs: - https://github.com/apache/superset/pull/23356 - https://github.com/apache/superset/pull/23385 - https://github.com/apache/superset/pull/23401 Once we have that, I think we would still need the following steps: 1. Implement catalog-level permissions (@dpgaspar can probably help here). We also need to modify the parser to extract the catalog from queries, and have the security manager handle catalogs when checking for access. 2. Implement a `get_catalog_names` in the DB engine specs that support catalogs (Presto, Trino, Snowflake, BigQuery, Postgres, ...?). Also update their `adjust_engine_params` methods to modify the SQL Alchemy URI to use the chosen catalog. 3. Add a catalog dropdown to SQL Lab, and make sure the selected catalog is being passed to `_get_sqla_engine` in the database model, and from there passed to `adjust_engine_params`. 4. Modify the dataset model and add a `catalog` attribute. 5. Add a catalog dropdown to the dataset creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
