eschutho opened a new pull request, #23415:
URL: https://github.com/apache/superset/pull/23415

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   We'd like to use this feature from 
https://github.com/apache/superset/pull/20114 for the use case where someone 
doesn't have user impersonation on for the database, but still wants to create 
different cache keys in Superset for each user. I believe that some users 
prefer to use their database for RLS, but this will enable them to use the 
Superset RLS instead. 
   
   I thought about adapting with the existing key, but I didn't want to change 
any functionality, so instead I created a new key `CACHE_QUERY_BY_USER` 
   
   
   ### TESTING INSTRUCTIONS
   With the `CACHE_QUERY_BY_USER` flag on, run a query with two different 
users, with different superset rls permissions and you should get different 
cached results. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to