eschutho commented on code in PR #23174:
URL: https://github.com/apache/superset/pull/23174#discussion_r1140855090
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx:
##########
@@ -566,6 +602,93 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
const [useSSHTunneling, setUseSSHTunneling] = useState<boolean>(false);
+ const createPostProcessingCallbacks = useRef<any>({});
+ const updatePostProcessingCallbacks = useRef<any>({});
Review Comment:
If I understand this correctly, it looks like the child is sending a
function from a lower level component up to the a higher component by attaching
it to a ref, is that right? Would it be easier to import the extension into
this parent index component, and then you can call the create and update
callbacks later in the parent and then pass down just the visual components to
the ExtraOptions? That way you don't have to pass the callbacks up to the
parent. I'm not sure if that's necessarily the solution, but I know that these
extension points are complicated, so trying to help suggest a simpler solution
if there is one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
