LahmerIlyas opened a new pull request, #23554: URL: https://github.com/apache/superset/pull/23554
### SUMMARY Exporting the full CSV on the table chart with server pagination was not working properly as it was exporting only the selected page. After investigation, I found that the issue is because the row limit was being overridden. As a fix, I added a check to verify if the result type is full, and in that case, we won't allow editing the row_limit prop. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF [Bug Solution After.webm](https://user-images.githubusercontent.com/31275446/229398750-5708a65f-6f7b-4493-9e0d-6bb91320715e.webm) ### TESTING INSTRUCTIONS - On your config.py file, you need to enable `ALLOW_FULL_CSV_EXPORT` flag - Go to a table with server pagination enabled - On the action menu, select download and click on `Export FULL CSV` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: Fixes #20724 - [ ] Required feature flags: ALLOW_FULL_CSV_EXPORT - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
