john-bodley opened a new pull request, #23597: URL: https://github.com/apache/superset/pull/23597
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This PR fixes an error when applying post processing for a pivot chart et al. when the underlying datasource is non-materialized, i.e., a `superset.models.sql_lab.Query` object as opposed to a materialized datasource, i.e., a `superset.connectors.base.models.BaseDatasource` object. The underlying issue is that the `superset.models.sql_lab.Query.data` property did not include the `verbose_map` field which is present in the `superset.connectors.base.models.BaseDatasource.data`property, i.e., ``` File "<prefix>/superset/charts/post_processing.py", line 352, in apply_post_process df.rename(columns=datasource.data["verbose_map"], inplace=True) KeyError: 'verbose_map' ``` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS CI and tested locally. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
