jfrag1 commented on PR #23112: URL: https://github.com/apache/superset/pull/23112#issuecomment-1498379139
> This looks good, but let's do what @dpgaspar recommended and add the method to `constants.py` so we don't add a new unneeded permission. I added it just now, but I'm curious if the `permission_name` decorator does the same thing? Is the difference that with only the decorator, a DB record will still be created for the `copy_dash` permission but it won't do anything? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
