villebro commented on code in PR #23396:
URL: https://github.com/apache/superset/pull/23396#discussion_r1159326208
##########
superset-frontend/plugins/plugin-chart-echarts/src/Gauge/transformProps.ts:
##########
@@ -146,7 +147,12 @@ export default function transformProps(
const transformedData: GaugeDataItemOption[] = data.map(
(data_point, index) => {
const name = groupbyLabels
- .map(column => `${column}: ${data_point[column]}`)
+ .map(
+ column =>
+ `${verboseMap ? verboseMap[column] : column}: ${
+ data_point[column]
+ }`,
+ )
Review Comment:
I don't believe this won't work if you have a column that doesn't have a
verbose name defined for it. I believe you need to do something like this:
```suggestion
.map(
column =>
`${verboseMap[column] || column}: ${data_point[column]}`,
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
