hbruch commented on PR #21479: URL: https://github.com/apache/superset/pull/21479#issuecomment-1501058844
I went through the suggested changes and most of them were already handled and merged via @AndVK's https://github.com/apache/superset/pull/21816 (thanks again!). For the very few missing translations I spotted, I'll submit a PR. Besides this, two changes suggested by @AndVK are still open and require some code changes: * internationalize [table columns](https://github.com/apache/superset/blob/master/superset-frontend/src/components/TableLoader/index.tsx#L68-L71) * humanized times/ time deltas. For these, I also think, they should be handled client side Another category of missing translations are error messages. Not sure, which of the are really end user facing, but a couple of them them will be (e.g. in [controls.ts](https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-echarts/src/utils/controls.ts#L35) or [TTestTable.jsx](https://github.com/apache/superset/blob/master/superset-frontend/plugins/legacy-plugin-chart-paired-t-test/src/TTestTable.jsx#L176)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
