betodealmeida commented on code in PR #23666:
URL: https://github.com/apache/superset/pull/23666#discussion_r1164579385
##########
superset/models/helpers.py:
##########
@@ -1314,7 +1314,7 @@ def dttm_sql_literal(self, dttm: sa.DateTime, col_type:
Optional[str]) -> str:
if sql:
return sql
- return f'{dttm.strftime("%Y-%m-%d %H:%M:%S.%f")}'
+ return f"""'{dttm.strftime("%Y-%m-%d %H:%M:%S.%f")}'"""
Review Comment:
Later this gets wrapped in a `text()` clause (see
`BaseEnginesSpec.get_text_clause`) so the string itself will contain single
quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
