michael-s-molina commented on code in PR #23656:
URL: https://github.com/apache/superset/pull/23656#discussion_r1164617385
##########
superset/db_engine_specs/presto.py:
##########
@@ -561,10 +561,18 @@ def latest_partition(
)
column_names = indexes[0]["column_names"]
- part_fields = [(column_name, True) for column_name in column_names]
- sql = cls._partition_query(table_name, database, 1, part_fields)
- df = database.get_df(sql, schema)
- return column_names, cls._latest_partition_from_df(df)
+
+ return column_names, cls._latest_partition_from_df(
+ df=database.get_df(
+ sql=cls._partition_query(
+ table_name,
+ database,
Review Comment:
No problem. I generally like to always provide the pair to remove any
ordering requirements. By the way, keyword arguments is one of my favorite
Python features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
