arkid15r opened a new pull request, #23685: URL: https://github.com/apache/superset/pull/23685
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY The purpose of this PR is fixing incorrect datetime_eval for holiday results containing more than one entry (even with observed=False flag set): - Bump holidays version range from ">=0.17.2, <0.18" to ">=0.22, <0.23" - Change holiday search result evaluation logic for multiple date cases - Change holiday lookup from `icontains` (default) to `istartswith`. - Add tests for the cases ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> The added unit tests would fail with the currently used approach. The described cases include: - multiple holidays per year (happens for Islamic calendar countries) e.g., "Eid al-Fitr" holidays for Saudi Arabia (JAN and DEC of 2000) - multiple holidays per lookup name, e.g., "Independence Day" for US years after 2021 (Independence Day, Juneteenth National Independence Day) ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: no issue, small PR - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
