michael-s-molina commented on code in PR #23674:
URL: https://github.com/apache/superset/pull/23674#discussion_r1166667974
##########
superset/db_engine_specs/presto.py:
##########
@@ -423,24 +423,30 @@ def get_function_names(cls, database: Database) ->
List[str]:
return database.get_df("SHOW FUNCTIONS")["Function"].tolist()
@classmethod
- def _partition_query( # pylint: disable=too-many-arguments,too-many-locals
+ def _partition_query( # pylint:
disable=too-many-arguments,too-many-locals,unused-argument
cls,
table_name: str,
+ schema: Optional[str],
+ indexes: List[Dict[str, Any]],
database: Database,
limit: int = 0,
order_by: Optional[List[Tuple[str, bool]]] = None,
filters: Optional[Dict[Any, Any]] = None,
) -> str:
- """Returns a partition query
+ """
+ Return a partition query.
+
+ Note the unused arguments are exposed for sub-classing purposes where
custom
+ integrations may require the schema, indexes, etc. to build the
paritiion query.
Review Comment:
```suggestion
integrations may require the schema, indexes, etc. to build the
partition query.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
