jfrag1 opened a new pull request, #23697:
URL: https://github.com/apache/superset/pull/23697

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Overwriting datasets in particular can take a long time to run since it 
makes a request to `PUT /api/v1/datasets/{id}?override_columns=true`, which 
will execute the updated query on the DB.  Requests that can take this long 
should have a loading indicator to let the user know something is happening and 
not broken.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before:
   
![dataset_overwrite_before](https://user-images.githubusercontent.com/47196419/232168299-f984ab8d-b35e-4d32-b511-cd8c44ac8d7c.gif)
   
   After:
   
![dataset_overwrite_after](https://user-images.githubusercontent.com/47196419/232168308-5e42235d-f5ef-43b8-b15f-d03359c417de.gif)
   
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to