gbusch commented on code in PR #23064:
URL: https://github.com/apache/superset/pull/23064#discussion_r1167560254
##########
superset-frontend/packages/superset-ui-chart-controls/test/utils/getColorFormatters.test.ts:
##########
@@ -188,6 +188,22 @@ describe('getColorFunction()', () => {
expect(colorFunction(150)).toBeUndefined();
});
+ it('getColorFunction BETWEEN_OR_EQUAL without opacity', () => {
+ const colorFunction = getColorFunction(
+ {
+ operator: COMPARATOR.BETWEEN_OR_EQUAL,
+ targetValueLeft: 50,
+ targetValueRight: 100,
+ colorScheme: '#FF0000',
+ column: 'count',
+ },
+ countValues,
+ false,
+ );
+ expect(colorFunction(50)).toEqual('#FF0000');
+ expect(colorFunction(100)).toEqual('#FF0000');
Review Comment:
added tests, please resolve it ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
