Usiel commented on PR #22849: URL: https://github.com/apache/superset/pull/22849#issuecomment-1511786769
> Does WEBDRIVER_BASEURL need to end in a slash? Mine does not in my config and reports etc. all work correctly, I have `WEBDRIVER_BASEURL="http://superset_app:8088"` Thanks for checking. You are right, reports are fine, as the function that is called ultimately uses a library that is clever enough to handle both cases (ending in a slash or not), see [urls.py#L32](https://github.com/apache/superset/blob/2.1.0/superset/utils/urls.py#L32). However, your cache warmup might be broken, because [cache.py#L43]( https://github.com/apache/superset/blob/2.1.0/superset/tasks/cache.py#L43) does not handle the base URL ending with a slash. I'm happy to improve this, but not sure if you all would prefer a separate PR for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
