villebro opened a new pull request, #23720:
URL: https://github.com/apache/superset/pull/23720

   ### SUMMARY
   When copying SQL Lab results from the query history to the clipboard, the 
headers are not included in the payload. This PR adds the headers.
   
   ### AFTER
   Now when you copy this:
   <img width="885" alt="image" 
src="https://user-images.githubusercontent.com/33317356/232719283-ef009167-4ac6-4a8b-992e-bab757711113.png";>
   
   You get this (the headers may appear to be off, but it's because they're tab 
separated, which isn't reflected in the code block):
   ```
   ds   gender  name    num     state   num_boys        num_girls
   1965-01-01 00:00:00.000000   boy     Aaron   369     CA      369     0
   1965-01-01 00:00:00.000000   girl    Amy     494     CA      0       494
   1965-01-01 00:00:00.000000   girl    Andrea  607     CA      0       607
   1965-01-01 00:00:00.000000   boy     Andrew  933     CA      933     0
   1965-01-01 00:00:00.000000   girl    Angela  1066    CA      0       1066
   1965-01-01 00:00:00.000000   girl    Anna    564     CA      0       564
   1965-01-01 00:00:00.000000   boy     Anthony 1928    CA      1928    0
   1965-01-01 00:00:00.000000   girl    Barbara 922     CA      0       922
   1965-01-01 00:00:00.000000   boy     Bradley 395     CA      395     0
   1965-01-01 00:00:00.000000   girl    Brenda  961     CA      0       961
   ```
   
   ### BEFORE
   Previously you got this:
   ```
   1965-01-01 00:00:00.000000   boy     Aaron   369     CA      369     0
   1965-01-01 00:00:00.000000   girl    Amy     494     CA      0       494
   1965-01-01 00:00:00.000000   girl    Andrea  607     CA      0       607
   1965-01-01 00:00:00.000000   boy     Andrew  933     CA      933     0
   1965-01-01 00:00:00.000000   girl    Angela  1066    CA      0       1066
   1965-01-01 00:00:00.000000   girl    Anna    564     CA      0       564
   1965-01-01 00:00:00.000000   boy     Anthony 1928    CA      1928    0
   1965-01-01 00:00:00.000000   girl    Barbara 922     CA      0       922
   1965-01-01 00:00:00.000000   boy     Bradley 395     CA      395     0
   1965-01-01 00:00:00.000000   girl    Brenda  961     CA      0       961
   ```
   
   ### TESTING INSTRUCTIONS
   1. Run a query in SQL Lab
   2. Go to Query History
   3. Click "View" results
   4. Click "Copy to clipboard"
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to