sfirke commented on PR #22849: URL: https://github.com/apache/superset/pull/22849#issuecomment-1513248065
I searched the codebase for the arguments removed by this PR and agree, they are not in use and you got all mentions of them. I can't approve PRs but would approve this one 😁 Re: > However, your cache warmup might be broken, because [cache.py#L43](https://github.com/apache/superset/blob/2.1.0/superset/tasks/cache.py#L43) does not handle the base URL ending with a slash. I'm happy to improve this, but not sure if you all would prefer a separate PR for that. Indeed I've never gotten cache warmup to work 😆 I did not dig into the sub-functions but I see what you're saying, that there's processing done by that library that's not present in cache.py. I think that would be a nice improvement to add it to cache.py#43 to bring it into parity with urls.py, and a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
