Antonio-RiveroMartnez commented on code in PR #22849: URL: https://github.com/apache/superset/pull/22849#discussion_r1171890879
########## docs/docs/installation/alerts-reports.mdx: ########## @@ -163,9 +163,9 @@ WEBDRIVER_OPTION_ARGS = [ ] # This is for internal use, you can keep http -WEBDRIVER_BASEURL = "http://superset:8088"; -# This is the link sent to the recipient. Change to your domain, e.g. https://superset.mydomain.com -WEBDRIVER_BASEURL_USER_FRIENDLY = "http://localhost:8088"; +WEBDRIVER_BASEURL = "http://superset:8088/"; Review Comment: Hey! Thanks for the fix! 🎉 just a comment, could we leave this as is and instead address the correct handling of both cases (with our without trailing /) in the get_url method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
