[GitHub] [superset] villebro opened a new pull request, #23748: feat(adhoc-column): add resize option

[via GitHub]

villebro opened a new pull request, #23748:
URL: https://github.com/apache/superset/pull/23748

   ### SUMMARY
   This PR adds resizing to the adhoc column popover, and is based on what's 
currently used in the metric and filter popovers. This is often needed when 
writing custom SQL expressions. In addition, the height multiplier of 2 is 
removed from the metric and filter popovers, as it only makes intuitive sense 
when the popover placement is set to `left`, in which case the popover grows 
both upwards and downwards. Since we let AntD decide which placement to use, it 
makes more sense to not apply multiplier, as the popover often grows out of 
bounds quickly, causing weird side-effects when the placement changes. This 
also felt unintuitive, as the vertical movement was doubled, as opposed to 
horizontal movement, which was not multiplied.
   
   ### AFTER
   Now the adhoc column popover is resizable:
   <img width="806" alt="image" 
src="https://user-images.githubusercontent.com/33317356/233337423-e379c836-7e38-4f6b-a8cc-638ab1b9c79f.png";>
   
   Also, the removed multiplier makes the resize action be in line with the 
vertical mouse movement:
   
   
https://user-images.githubusercontent.com/33317356/233341632-b633fdba-1a5d-40a3-b909-f939c8191569.mp4
   
   ### BEFORE
   Previously the adhoc column popover wasn't resizable:
   <img width="647" alt="image" 
src="https://user-images.githubusercontent.com/33317356/233339014-04fae34a-7808-473c-aa02-e3f4eb1be536.png";>
   
   Also, the multiplier caused the resize action to feel unintuitive with top 
placement:
   
   
https://user-images.githubusercontent.com/33317356/233341488-04728fca-a063-43b8-9109-117801f8ae0c.mp4
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org