villebro commented on code in PR #20075:
URL: https://github.com/apache/superset/pull/20075#discussion_r1173362701
##########
superset-frontend/src/types/bootstrapTypes.ts:
##########
@@ -150,6 +151,7 @@ export interface CommonBootstrapData {
extra_sequential_color_schemes: SequentialSchemeConfig[];
theme_overrides: JsonObject;
menu_data: MenuData;
+ d3_format: Partial<FormatLocaleDefinition>;
Review Comment:
Do we really need `Partial` here? It appears that the added `dict` in
`config.py` defines all properties of `FormatLocaleDefinition`. If not, let's
make sure the type in `config.py` reflects the partialness (this could be done
by adding `total=False` to the Python class that's extending `TypedDict`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
