LeonardSchuler opened a new pull request, #23771:
URL: https://github.com/apache/superset/pull/23771

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   In 
[superset/sql_parse.py](https://github.com/apache/superset/blob/master/superset/sql_parse.py#L67)
 sqlparse.keywords.FLAGS is used.
   However, sqlparse has removed the FLAGS variable from the code 
[sqlparse/kewords.py](https://github.com/andialbrecht/sqlparse/blob/0.4.4/sqlparse/keywords.py).
   
   This leads to an AttributeError when running the CLI command
   ```
   $ superset db upgrade
   AttributeError: module 'sqlparse.keywords' has no attribute 'FLAGS'
   ```
   
   This PR fixes that by replacing the sqlparse.keywords.FLAGS variable in 
sql_parse.py with the value originally defined in sqlparse.keywords.FLAGS.
   
   
   ### TESTING INSTRUCTIONS
   
   ### ADDITIONAL INFORMATION
   
   Fixes #23742 
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to