[GitHub] [superset] villebro commented on a diff in pull request #23772: chore(e2e): skip the worst offender of flaky tests.

Fri, 21 Apr 2023 09:14:24 -0700 


villebro commented on code in PR #23772:
URL: https://github.com/apache/superset/pull/23772#discussion_r1173951641


##########
superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts:
##########
@@ -734,7 +734,8 @@ describe('Dashboard edit', () => {
       cy.getBySel('dashboard-charts-filter-search-input').clear();
     });
 
-    it('should disable the Save button when undoing', () => {
+    // TODO fix this test! This was the #1 flaky test as of 4/21/23 according 
to cypress dashboard.
+    xit('should disable the Save button when undoing', () => {

Review Comment:
   not sure about worst offender; This test was restarted 11 times before I 
finally caved in and `xit`ed it in #23751 😆 
   
![image](https://user-images.githubusercontent.com/33317356/233684932-4989fff7-a5b7-4bc4-bb72-2ac4111da586.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to