justinpark opened a new pull request, #23778:
URL: https://github.com/apache/superset/pull/23778

   ### SUMMARY
   
   This bug introduced by #20282 
   After resize target element has scrollbars, the chart keeps flushing 
scrollbars on and oft.
   It because keeps re-calculate the element's size due to the content size is 
different with/without scrollbars.
   
   This commit replaces the resize observe element with the parent element 
(which has no scrollbars) and then calculate the chartPanel element from 
onResize handler.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   After:
   
   
https://user-images.githubusercontent.com/1392866/233742823-90c0ec40-997f-4341-8560-40a7e7ff68fe.mov
   
   Before:
   
   
https://user-images.githubusercontent.com/1392866/233742847-88d0bb9c-4abd-4334-8303-6c8c014e7ffd.mov
   
   ### TESTING INSTRUCTIONS
   Open a chart explore
   Resize window width smaller
   check the chart scroll
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to