ebaratte commented on code in PR #20075:
URL: https://github.com/apache/superset/pull/20075#discussion_r1176298504
##########
superset-frontend/src/types/bootstrapTypes.ts:
##########
@@ -150,6 +151,7 @@ export interface CommonBootstrapData {
extra_sequential_color_schemes: SequentialSchemeConfig[];
theme_overrides: JsonObject;
menu_data: MenuData;
+ d3_format: Partial<FormatLocaleDefinition>;
Review Comment:
I think we do; the way the code is set up, a user can specify a subset of
the formatting options in `config.py` (`total=False` in the type definition).
The default values are set in the front (`D3FormatConfig.ts`, and
`setD3Format()` in `NumberFormatterRegistry.ts:52`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
