kgabryje commented on code in PR #23698:
URL: https://github.com/apache/superset/pull/23698#discussion_r1176350443
##########
superset-frontend/plugins/plugin-chart-echarts/src/Graph/EchartsGraph.tsx:
##########
@@ -143,7 +150,18 @@ export default function EchartsGraph({
drillToDetail: drillToDetailFilters,
crossFilter: getCrossFilterDataMask(node),
drillBy: node && {
- filters: [{ col: node.col, op: '==', val: node.name }],
+ filters: [
+ {
+ col: node.col,
+ op: '==',
+ val: node.name,
+ formattedVal: formatSeriesName(node.name, {
+ timeFormatter: getTimeFormatter(node.name),
Review Comment:
The argument of `getTimeFormatter/getNumberFormatter` should be the
time/number format selected by the user, available in
`formData.dateFormat/formData.numberFormat` (or sth similar, not sure if the
field name is the same for all charts)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
