geido commented on code in PR #23849: URL: https://github.com/apache/superset/pull/23849#discussion_r1180311023
########## superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts: ########## @@ -0,0 +1,712 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +// eslint-disable-next-line import/no-extraneous-dependencies +import { Interception } from 'cypress/types/net-stubbing'; +import { waitForChartLoad } from 'cypress/utils'; +import { SUPPORTED_CHARTS_DASHBOARD } from 'cypress/utils/urls'; +import { SUPPORTED_TIER1_CHARTS, SUPPORTED_TIER2_CHARTS } from './utils'; + +const interceptV1ChartData = (alias = 'v1Data') => { + cy.intercept('/api/v1/chart/data*').as(alias); +}; + +const interceptLegacyChartData = () => { + cy.intercept('/superset/explore_json*').as('legacyData'); +}; + +const interceptFormDataKey = () => { + cy.intercept('/api/v1/explore/form_data').as('formDataKey'); Review Comment: For these other interceptors, it would be good to place the, in the utils that most make sense. For example, if this request happens only in the dashboard, we could put them in dashboard/utils for reusability ########## superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts: ########## @@ -0,0 +1,712 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +// eslint-disable-next-line import/no-extraneous-dependencies +import { Interception } from 'cypress/types/net-stubbing'; +import { waitForChartLoad } from 'cypress/utils'; +import { SUPPORTED_CHARTS_DASHBOARD } from 'cypress/utils/urls'; +import { SUPPORTED_TIER1_CHARTS, SUPPORTED_TIER2_CHARTS } from './utils'; + +const interceptV1ChartData = (alias = 'v1Data') => { + cy.intercept('/api/v1/chart/data*').as(alias); +}; + +const interceptLegacyChartData = () => { Review Comment: I think for this you can import the existing `interceptExploreJson` from explore/utils.ts ########## superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts: ########## @@ -0,0 +1,712 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +// eslint-disable-next-line import/no-extraneous-dependencies +import { Interception } from 'cypress/types/net-stubbing'; +import { waitForChartLoad } from 'cypress/utils'; +import { SUPPORTED_CHARTS_DASHBOARD } from 'cypress/utils/urls'; +import { SUPPORTED_TIER1_CHARTS, SUPPORTED_TIER2_CHARTS } from './utils'; + +const interceptV1ChartData = (alias = 'v1Data') => { + cy.intercept('/api/v1/chart/data*').as(alias); +}; + +const interceptLegacyChartData = () => { + cy.intercept('/superset/explore_json*').as('legacyData'); +}; + +const interceptFormDataKey = () => { + cy.intercept('/api/v1/explore/form_data').as('formDataKey'); +}; + +const closeModal = () => { + cy.get('body').then($body => { + if ($body.find('[data-test="close-drill-by-modal"]').length) { + cy.getBySel('close-drill-by-modal').click({ force: true }); + } + }); +}; + +const setTopLevelTab = (tabName: string) => { + cy.get("div#TABS-TOP div[role='tab']").contains(tabName).click(); +}; + +const openTableContextMenu = ( + cellContent: string, + tableSelector = "[data-test-viz-type='table']", +) => { + cy.get(tableSelector) + .scrollIntoView() + .contains(cellContent) + .first() + .rightclick(); +}; + +const drillBy = (targetDrillByColumn: string, isLegacy = false) => { + if (isLegacy) { + interceptLegacyChartData(); + } else { + interceptV1ChartData(); + } + + cy.get('.ant-dropdown:not(.ant-dropdown-hidden)') + .first() + .find("[role='menu'] [role='menuitem'] [title='Drill by']") + .trigger('mouseover'); + cy.get( + '.ant-dropdown-menu-submenu:not(.ant-dropdown-menu-hidden) [data-test="drill-by-submenu"]', + ) + .find('[role="menuitem"]') + .contains(new RegExp(`^${targetDrillByColumn}$`)) + .first() + .click({ force: true }); + + if (isLegacy) { + return cy.wait('@legacyData'); + } + return cy.wait('@v1Data'); +}; + +const verifyExpectedFormData = ( + interceptedRequest: Interception, + expectedFormData: Record<string, any>, +) => { + const actualFormData = interceptedRequest.request.body?.form_data; + Object.entries(expectedFormData).forEach(([key, val]) => { + expect(actualFormData?.[key]).to.eql(val); + }); +}; + +const testEchart = ( + vizType: string, + chartName: string, + drillClickCoordinates: [[number, number], [number, number]], + furtherDrillDimension = 'name', +) => { + cy.get(`[data-test-viz-type='${vizType}'] canvas`).then($canvas => { + // click 'boy' + cy.wrap($canvas) + .scrollIntoView() + .trigger( + 'mouseover', + drillClickCoordinates[0][0], + drillClickCoordinates[0][1], + ) + .rightclick(drillClickCoordinates[0][0], drillClickCoordinates[0][1]); + + drillBy('state').then(intercepted => { + verifyExpectedFormData(intercepted, { + groupby: ['state'], + adhoc_filters: [ + { + clause: 'WHERE', + comparator: 'boy', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'gender', + }, + ], + }); + }); + + cy.getBySel(`"Drill by: ${chartName}-modal"`).as('drillByModal'); + + cy.get('@drillByModal') + .find('.draggable-trigger') + .should('contain', chartName); + + cy.get('@drillByModal') + .find('.ant-breadcrumb') + .should('be.visible') + .and('contain', 'gender (boy)') + .and('contain', '/') + .and('contain', 'state'); + + cy.get('@drillByModal') + .find('[data-test="drill-by-chart"]') + .should('be.visible'); + + // further drill + cy.get(`[data-test="drill-by-chart"] canvas`).then($canvas => { Review Comment: Can use the `cy.getBySel` instead ########## superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts: ########## @@ -0,0 +1,712 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +// eslint-disable-next-line import/no-extraneous-dependencies +import { Interception } from 'cypress/types/net-stubbing'; +import { waitForChartLoad } from 'cypress/utils'; +import { SUPPORTED_CHARTS_DASHBOARD } from 'cypress/utils/urls'; +import { SUPPORTED_TIER1_CHARTS, SUPPORTED_TIER2_CHARTS } from './utils'; + +const interceptV1ChartData = (alias = 'v1Data') => { + cy.intercept('/api/v1/chart/data*').as(alias); +}; + +const interceptLegacyChartData = () => { + cy.intercept('/superset/explore_json*').as('legacyData'); +}; + +const interceptFormDataKey = () => { + cy.intercept('/api/v1/explore/form_data').as('formDataKey'); +}; + +const closeModal = () => { + cy.get('body').then($body => { + if ($body.find('[data-test="close-drill-by-modal"]').length) { + cy.getBySel('close-drill-by-modal').click({ force: true }); + } + }); +}; + +const setTopLevelTab = (tabName: string) => { Review Comment: I think we have this already in drilltodetail tests. Should it be moved to the utils? ########## superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts: ########## @@ -0,0 +1,712 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +// eslint-disable-next-line import/no-extraneous-dependencies +import { Interception } from 'cypress/types/net-stubbing'; +import { waitForChartLoad } from 'cypress/utils'; +import { SUPPORTED_CHARTS_DASHBOARD } from 'cypress/utils/urls'; +import { SUPPORTED_TIER1_CHARTS, SUPPORTED_TIER2_CHARTS } from './utils'; + +const interceptV1ChartData = (alias = 'v1Data') => { + cy.intercept('/api/v1/chart/data*').as(alias); +}; + +const interceptLegacyChartData = () => { + cy.intercept('/superset/explore_json*').as('legacyData'); +}; + +const interceptFormDataKey = () => { + cy.intercept('/api/v1/explore/form_data').as('formDataKey'); +}; + +const closeModal = () => { + cy.get('body').then($body => { + if ($body.find('[data-test="close-drill-by-modal"]').length) { + cy.getBySel('close-drill-by-modal').click({ force: true }); + } + }); +}; + +const setTopLevelTab = (tabName: string) => { + cy.get("div#TABS-TOP div[role='tab']").contains(tabName).click(); +}; + +const openTableContextMenu = ( + cellContent: string, + tableSelector = "[data-test-viz-type='table']", +) => { + cy.get(tableSelector) + .scrollIntoView() + .contains(cellContent) + .first() + .rightclick(); +}; + +const drillBy = (targetDrillByColumn: string, isLegacy = false) => { + if (isLegacy) { + interceptLegacyChartData(); + } else { + interceptV1ChartData(); + } + + cy.get('.ant-dropdown:not(.ant-dropdown-hidden)') + .first() + .find("[role='menu'] [role='menuitem'] [title='Drill by']") + .trigger('mouseover'); + cy.get( + '.ant-dropdown-menu-submenu:not(.ant-dropdown-menu-hidden) [data-test="drill-by-submenu"]', + ) + .find('[role="menuitem"]') + .contains(new RegExp(`^${targetDrillByColumn}$`)) + .first() + .click({ force: true }); + + if (isLegacy) { + return cy.wait('@legacyData'); + } + return cy.wait('@v1Data'); +}; + +const verifyExpectedFormData = ( + interceptedRequest: Interception, + expectedFormData: Record<string, any>, +) => { + const actualFormData = interceptedRequest.request.body?.form_data; + Object.entries(expectedFormData).forEach(([key, val]) => { + expect(actualFormData?.[key]).to.eql(val); + }); +}; + +const testEchart = ( + vizType: string, + chartName: string, + drillClickCoordinates: [[number, number], [number, number]], + furtherDrillDimension = 'name', +) => { + cy.get(`[data-test-viz-type='${vizType}'] canvas`).then($canvas => { + // click 'boy' + cy.wrap($canvas) + .scrollIntoView() + .trigger( + 'mouseover', + drillClickCoordinates[0][0], + drillClickCoordinates[0][1], + ) + .rightclick(drillClickCoordinates[0][0], drillClickCoordinates[0][1]); + + drillBy('state').then(intercepted => { + verifyExpectedFormData(intercepted, { + groupby: ['state'], + adhoc_filters: [ + { + clause: 'WHERE', + comparator: 'boy', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'gender', + }, + ], + }); + }); + + cy.getBySel(`"Drill by: ${chartName}-modal"`).as('drillByModal'); + + cy.get('@drillByModal') + .find('.draggable-trigger') + .should('contain', chartName); + + cy.get('@drillByModal') + .find('.ant-breadcrumb') + .should('be.visible') + .and('contain', 'gender (boy)') + .and('contain', '/') + .and('contain', 'state'); + + cy.get('@drillByModal') + .find('[data-test="drill-by-chart"]') + .should('be.visible'); + + // further drill + cy.get(`[data-test="drill-by-chart"] canvas`).then($canvas => { + // click 'other' + cy.wrap($canvas) + .scrollIntoView() + .trigger( + 'mouseover', + drillClickCoordinates[1][0], + drillClickCoordinates[1][1], + ) + .rightclick(drillClickCoordinates[1][0], drillClickCoordinates[1][1]); + + drillBy(furtherDrillDimension).then(intercepted => { + verifyExpectedFormData(intercepted, { + groupby: [furtherDrillDimension], + adhoc_filters: [ + { + clause: 'WHERE', + comparator: 'boy', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'gender', + }, + { + clause: 'WHERE', + comparator: 'other', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'state', + }, + ], + }); + }); + + cy.get('@drillByModal') + .find('[data-test="drill-by-chart"]') + .should('be.visible'); + + // undo - back to drill by state + interceptV1ChartData('drillByUndo'); + cy.get('@drillByModal') + .find('.ant-breadcrumb') + .should('be.visible') + .and('contain', 'gender (boy)') + .and('contain', '/') + .and('contain', 'state (other)') + .and('contain', furtherDrillDimension) + .contains('state (other)') + .click(); + cy.wait('@drillByUndo').then(intercepted => { + verifyExpectedFormData(intercepted, { + groupby: ['state'], + adhoc_filters: [ + { + clause: 'WHERE', + comparator: 'boy', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'gender', + }, + ], + }); + }); + + cy.get('@drillByModal') + .find('.ant-breadcrumb') + .should('be.visible') + .and('contain', 'gender (boy)') + .and('contain', '/') + .and('not.contain', 'state (other)') + .and('not.contain', furtherDrillDimension) + .and('contain', 'state'); + + cy.get('@drillByModal') + .find('[data-test="drill-by-chart"]') + .should('be.visible'); + }); + }); +}; + +describe('Drill by modal', () => { + beforeEach(() => { + closeModal(); + }); + before(() => { + cy.visit(SUPPORTED_CHARTS_DASHBOARD); + }); + + describe('Modal actions + Table', () => { + before(() => { + closeModal(); + setTopLevelTab('Tier 1'); + SUPPORTED_TIER1_CHARTS.forEach(waitForChartLoad); + }); + + it('opens the modal from the context menu', () => { + openTableContextMenu('boy'); + drillBy('state').then(intercepted => { + verifyExpectedFormData(intercepted, { + groupby: ['state'], + adhoc_filters: [ + { + clause: 'WHERE', + comparator: 'boy', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'gender', + }, + ], + }); + }); + + cy.getBySel('"Drill by: Table-modal"').as('drillByModal'); + + cy.get('@drillByModal') + .find('.draggable-trigger') + .should('contain', 'Drill by: Table'); + + cy.get('@drillByModal') + .find('[data-test="metadata-bar"]') + .should('be.visible'); + + cy.get('@drillByModal') + .find('.ant-breadcrumb') + .should('be.visible') + .and('contain', 'gender (boy)') + .and('contain', '/') + .and('contain', 'state'); + + cy.get('@drillByModal') + .find('[data-test="drill-by-chart"]') + .should('be.visible') + .and('contain', 'state') + .and('contain', 'sum__num'); + + // further drilling + openTableContextMenu('CA', '[data-test="drill-by-chart"]'); + drillBy('name').then(intercepted => { + verifyExpectedFormData(intercepted, { + groupby: ['name'], + adhoc_filters: [ + { + clause: 'WHERE', + comparator: 'boy', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'gender', + }, + { + clause: 'WHERE', + comparator: 'CA', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'state', + }, + ], + }); + }); + + cy.get('@drillByModal') + .find('[data-test="drill-by-chart"]') + .should('be.visible') + .and('not.contain', 'state') + .and('contain', 'name') + .and('contain', 'sum__num'); + + // undo - back to drill by state + interceptV1ChartData('drillByUndo'); + interceptFormDataKey(); + cy.get('@drillByModal') + .find('.ant-breadcrumb') + .should('be.visible') + .and('contain', 'gender (boy)') + .and('contain', '/') + .and('contain', 'state (CA)') + .and('contain', 'name') + .contains('state (CA)') + .click(); + cy.wait('@drillByUndo').then(intercepted => { + verifyExpectedFormData(intercepted, { + groupby: ['state'], + adhoc_filters: [ + { + clause: 'WHERE', + comparator: 'boy', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'gender', + }, + ], + }); + }); + + cy.get('@drillByModal') + .find('[data-test="drill-by-chart"]') + .should('be.visible') + .and('not.contain', 'name') + .and('contain', 'state') + .and('contain', 'sum__num'); + + cy.get('@drillByModal') + .find('.ant-breadcrumb') + .should('be.visible') + .and('contain', 'gender (boy)') + .and('contain', '/') + .and('not.contain', 'state (CA)') + .and('not.contain', 'name') + .and('contain', 'state'); + + cy.get('@drillByModal') + .find('[data-test="drill-by-display-toggle"]') + .contains('Table') + .click(); + + cy.getBySel('drill-by-chart').should('not.exist'); + + cy.get('@drillByModal') + .find('[data-test="drill-by-results-table"]') + .should('be.visible'); + + cy.wait('@formDataKey').then(intercept => { + cy.get('@drillByModal') + .contains('Edit chart') + .should('have.attr', 'href') + .and( + 'contain', + `/explore/?form_data_key=${intercept.response?.body?.key}`, + ); + }); + }); + }); + + describe('Tier 1 charts', () => { + before(() => { + closeModal(); + setTopLevelTab('Tier 1'); + SUPPORTED_TIER1_CHARTS.forEach(waitForChartLoad); + }); + + it('Pivot Table', () => { + openTableContextMenu('boy', "[data-test-viz-type='pivot_table_v2']"); + drillBy('name').then(intercepted => { + verifyExpectedFormData(intercepted, { + groupbyRows: ['state'], + groupbyColumns: ['name'], + adhoc_filters: [ + { + clause: 'WHERE', + comparator: 'boy', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'gender', + }, + ], + }); + }); + + cy.getBySel('"Drill by: Pivot Table-modal"').as('drillByModal'); + + cy.get('@drillByModal') + .find('.draggable-trigger') + .should('contain', 'Drill by: Pivot Table'); + + cy.get('@drillByModal') + .find('.ant-breadcrumb') + .should('be.visible') + .and('contain', 'gender (boy)') + .and('contain', '/') + .and('contain', 'name'); + + cy.get('@drillByModal') + .find('[data-test="drill-by-chart"]') + .should('be.visible') + .and('contain', 'state') + .and('contain', 'name') + .and('contain', 'sum__num') + .and('not.contain', 'Gender'); + + openTableContextMenu('CA', '[data-test="drill-by-chart"]'); + drillBy('ds').then(intercepted => { + verifyExpectedFormData(intercepted, { + groupbyColumns: ['name'], + groupbyRows: ['ds'], + adhoc_filters: [ + { + clause: 'WHERE', + comparator: 'boy', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'gender', + }, + { + clause: 'WHERE', + comparator: 'CA', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'state', + }, + ], + }); + }); + + cy.get('@drillByModal') + .find('[data-test="drill-by-chart"]') + .should('be.visible') + .and('contain', 'name') + .and('contain', 'ds') + .and('contain', 'sum__num') + .and('not.contain', 'state'); + + interceptV1ChartData('drillByUndo'); + + cy.get('@drillByModal') + .find('.ant-breadcrumb') + .should('be.visible') + .and('contain', 'gender (boy)') + .and('contain', '/') + .and('contain', 'name (CA)') + .and('contain', 'ds') + .contains('name (CA)') + .click(); + cy.wait('@drillByUndo').then(intercepted => { + verifyExpectedFormData(intercepted, { + groupbyRows: ['state'], + groupbyColumns: ['name'], + adhoc_filters: [ + { + clause: 'WHERE', + comparator: 'boy', + expressionType: 'SIMPLE', + operator: '==', + operatorId: 'EQUALS', + subject: 'gender', + }, + ], + }); + }); + + cy.get('@drillByModal') + .find('[data-test="drill-by-chart"]') + .should('be.visible') + .and('not.contain', 'ds') + .and('contain', 'state') + .and('contain', 'name') + .and('contain', 'sum__num'); + + cy.get('@drillByModal') + .find('.ant-breadcrumb') + .should('be.visible') + .and('contain', 'gender (boy)') + .and('contain', '/') + .and('not.contain', 'name (CA)') + .and('not.contain', 'ds') + .and('contain', 'name'); + }); + + it('Line chart', () => { + testEchart('echarts_timeseries_line', 'Time-Series Line Chart', [ + [70, 93], + [70, 93], + ]); + }); + + it('Area Chart', () => { + testEchart('echarts_area', 'Time-Series Area Chart', [ + [70, 93], + [70, 93], + ]); + }); + + it('Time-Series Scatter Chart', () => { + testEchart('echarts_timeseries_scatter', 'Time-Series Scatter Chart', [ + [70, 93], + [70, 93], + ]); + }); + + it('Time-Series Bar Chart V2', () => { + testEchart('echarts_timeseries_bar', 'Time-Series Bar Chart V2', [ + [70, 94], + [362, 68], + ]); + }); + + it('Pie Chart', () => { + testEchart('pie', 'Pie Chart', [ + [243, 167], + [534, 248], + ]); + }); + }); + + describe('Tier 2 charts', () => { + before(() => { + closeModal(); + setTopLevelTab('Tier 2'); + SUPPORTED_TIER2_CHARTS.forEach(waitForChartLoad); + }); + + it('Box Plot Chart', () => { + testEchart( + 'box_plot', + 'Box Plot Chart', + [ + [139, 277], + [787, 441], + ], + 'ds', + ); + }); + + it('Time-Series Generic Chart', () => { + testEchart('echarts_timeseries', 'Time-Series Generic Chart', [ + [70, 93], + [70, 93], + ]); + }); + + it('Time-Series Smooth Line Chart', () => { + testEchart('echarts_timeseries_smooth', 'Time-Series Smooth Line Chart', [ + [70, 93], + [70, 93], + ]); + }); + + it('Time-Series Step Line Chart', () => { + testEchart('echarts_timeseries_step', 'Time-Series Step Line Chart', [ + [70, 93], + [70, 93], + ]); + }); + + it('Funnel Chart', () => { + testEchart('funnel', 'Funnel Chart', [ + [154, 80], + [421, 39], + ]); + }); + + it('Gauge Chart', () => { + testEchart('gauge_chart', 'Gauge Chart', [ + [151, 95], + [300, 143], + ]); + }); + + it('Radar Chart', () => { + testEchart('radar', 'Radar Chart', [ + [182, 49], + [423, 91], + ]); + }); + + it('Treemap V2 Chart', () => { + testEchart('treemap_v2', 'Treemap V2 Chart', [ + [145, 84], + [220, 105], + ]); + }); + + it.only('Mixed Chart', () => { Review Comment: Ops `only` here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
