betodealmeida commented on code in PR #23868:
URL: https://github.com/apache/superset/pull/23868#discussion_r1180739200
##########
superset/db_engine_specs/postgres.py:
##########
@@ -205,17 +185,19 @@ def get_schema_from_engine_params(
to determine the schema for a non-qualified table in a query. In cases
like
that we raise an exception.
"""
- options = parse_options(connect_args)
- if search_path := options.get("search_path"):
- schemas = search_path.split(",")
- if len(schemas) > 1:
- raise Exception(
- "Multiple schemas are configured in the search path, which
means "
- "Superset is unable to determine the schema of unqualified
table "
- "names and enforce permissions."
- )
- return schemas[0]
-
+ options = re.split(r"-c\s?", connect_args.get("options", ""))
Review Comment:
I think we can actually get rid of the `get_schema_from_engine_params`
method here, since Redshift doesn't support passing `search_path` as far as I
could see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
