betodealmeida commented on code in PR #23641:
URL: https://github.com/apache/superset/pull/23641#discussion_r1182929608
##########
superset/charts/data/api.py:
##########
@@ -299,6 +299,9 @@ def data_from_cache(self, cache_key: str) -> Response:
"""
try:
cached_data = self._load_query_context_form_from_cache(cache_key)
+ # Set form_data in Flask Global as it is used as a fallback
+ # for async queries with jinja context
+ setattr(g, "form_data", cached_data)
Review Comment:
Is there a reason to do this instead of `g.form_data = cached_data`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
