drsm79 commented on code in PR #23834:
URL: https://github.com/apache/superset/pull/23834#discussion_r1183841676
##########
superset/initialization/__init__.py:
##########
@@ -476,13 +476,13 @@ def log_default_secret_key_warning() -> None:
)
logger.warning(bottom_banner)
- if self.config["SECRET_KEY"] == CHANGE_ME_SECRET_KEY:
+ if "secret" in self.config["SECRET_KEY"].lower():
Review Comment:
no, it's checking if secret appears anywhere in the string:
```
>>> k1 = 'secretthings'
>>> k2 = 'top_secret'
>>> k3 = 'a_very_SECRET_thing'
>>> for i in k1, k2, k3:
... 'secret' in i.lower()
...
True
True
True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
