dnskr opened a new pull request, #23923: URL: https://github.com/apache/superset/pull/23923
### SUMMARY The PR splits `Service` resource definitions into separate files according to Helm [Best Practices Guide](https://helm.sh/docs/chart_best_practices/templates/#structure-of-templates): > - Each resource definition should be in its own template file. Also `service-account.yaml` renamed to `serviceaccount.yaml` according to: > - Template file names should use dashed notation (my-example-configmap.yaml), not camelcase. The PR does not change any functionality of the chart. ### TESTING INSTRUCTIONS The following command creates `superset`, `superset-flower` and `superset-ws` services. ```shell helm template superset helm/superset --set supersetCeleryFlower.enabled=true --set supersetWebsockets.enabled=true ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
