cwegener commented on PR #23927: URL: https://github.com/apache/superset/pull/23927#issuecomment-1534594932
I missed a few `send_file` invocations which I've fixed. Some DB engine integration tests are still failing. Not sure yet why. I'll need to look into it. Mypy configuration looks broken to me though. I'm not sure if Mypy will even work the way we need it to work inside of pre-commit. Basically the problem is that some dependencies (e.g. Flask since version 2.0) have stubs include in their main distribution, while other dependencies require stubs to be installed vie the typeshed distribution. (i.e. the 'types-*' packages from PyPI). Currently, the mypy pre-commit hook is set up to install ALL available typeshed stubs, which includes the Flask 1.x stubs, which are the wrong stubs for us .... I'm trying to figure out if I can just explicitly define all the types-* packages in pre-commit that we need for Superset ... stay tuned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
