john-bodley opened a new pull request, #23944: URL: https://github.com/apache/superset/pull/23944
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY The `[Presto|Trino]EngineSpec._partition_query` functions provide arguments for both the schema and table name, however the later can include the schema—in the case when invoked from the `extra_table_metadata` method—which is somewhat confusing. This PR removes said logic ensuring that the `table_name` only includes the table name (which is guaranteed from the various calling endpoints [[1](https://github.com/apache/superset/blob/b7689fbe539038e939b6ae9a59855d131dc2b963/superset/databases/api.py#L699-L760), [2](https://github.com/apache/superset/blob/b7689fbe539038e939b6ae9a59855d131dc2b963/superset/views/core.py#L2059-L2074)]) and materializes the full table name within the `_partition_query` method. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
