michael-s-molina commented on code in PR #23853:
URL: https://github.com/apache/superset/pull/23853#discussion_r1187625186
##########
superset/cachekeys/schemas.py:
##########
@@ -51,3 +51,44 @@ class CacheInvalidationRequestSchema(Schema):
fields.Nested(Datasource),
metadata={"description": "A list of the data source and database
names"},
)
+
+
+class CacheWarmUpRequestSchema(Schema):
+ chart_id = fields.Integer(
+ metadata={"description": "The ID of the chart to warm up cache for"}
+ )
+ dashboard_id = fields.Integer(
+ metadata={
+ "description": "The ID of the dashboard to get filters for when
warming cache"
+ }
+ )
+ table_name = fields.String(
+ metadata={"description": "The name of the table to warm up cache for"}
+ )
Review Comment:
> An alternative could be to place it on api/v1/chart and/or api/v1/dataset
I would model these endpoints under the resources they refer to. I feels
really weird for me treating cache warm up as a first-level resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
