kgabryje commented on code in PR #23715:
URL: https://github.com/apache/superset/pull/23715#discussion_r1187687226
##########
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilter/index.js:
##########
@@ -135,6 +135,10 @@ export default class AdhocFilter {
getDefaultLabel() {
const label = this.translateToSql();
+ // If returned value is an object after changing dataset
+ if (typeof label === 'object') {
+ return label.column_name ?? '';
Review Comment:
Do I understand correctly that the bug occurs when `adhocFIlter.subject` is
an object and not a string? If so, maybe we could move the logic of extracting
column_name to `getSimpleSQLExpression`, line 298 - `let expression = subject
?? '';`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
