john-bodley commented on code in PR #23997:
URL: https://github.com/apache/superset/pull/23997#discussion_r1189227526
##########
superset/charts/post_processing.py:
##########
@@ -230,8 +230,6 @@ def pivot_table_v2(
Pivot table v2.
"""
verbose_map = datasource.data["verbose_map"] if datasource else None
- if form_data.get("granularity_sqla") == "all" and DTTM_ALIAS in df:
Review Comment:
This is likely a bug (see like #259), i.e., it likely should have been
`granularity` rather than `granularity_sqla` as this represents the Druid NoSQL
time grain (as opposed to the SQL time column) where `all` is a Druid NoSQL
concept which represents a single time grain/bucket to encapsulate the entire
time range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
