villebro commented on code in PR #23890:
URL: https://github.com/apache/superset/pull/23890#discussion_r1189726479
##########
.asf.yaml:
##########
@@ -66,12 +66,12 @@ github:
- cypress-matrix (3, chrome)
- docker-build
- frontend-build
- - pre-commit (3.8)
- - python-lint (3.8)
- - test-mysql (3.8)
- - test-postgres (3.8)
+ - pre-commit (3.9)
+ - python-lint (3.9)
+ - test-mysql (3.9)
- test-postgres (3.9)
- - test-sqlite (3.8)
+ - test-postgres (3.9)
Review Comment:
Shouldn't this be
```suggestion
- test-postgres (3.10)
```
##########
scripts/benchmark_migration.py:
##########
@@ -120,7 +120,7 @@ def find_models(module: ModuleType) -> List[Type[Model]]:
# sort topologically so we can create entities in order and
# maintain relationships (eg, create a database before creating
# a slice)
- sorter = TopologicalSorter()
+ sorter = TopologicalSorter() # type: TopologicalSorter[Any]
Review Comment:
Wouldn't this be the preferred way of specifying the type?
```python
sorter: TopologicalSorter[Any] = TopologicalSorter()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
