villebro commented on code in PR #24035:
URL: https://github.com/apache/superset/pull/24035#discussion_r1191987649
##########
superset/models/helpers.py:
##########
@@ -1945,7 +1958,6 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
inner_groupby_exprs = []
inner_select_exprs = []
for gby_name, gby_obj in groupby_series_columns.items():
- label = get_column_name(gby_name)
Review Comment:
bycatch - this variable was not used anywhere (apparently this function is
so bloated nowadays that the linters just give up on it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
