kgabryje opened a new pull request, #24102: URL: https://github.com/apache/superset/pull/24102
### SUMMARY Previously, when user applied drill by on a series of temporal dimension, the related adhoc filter would be a simple equality comparison to a timestamp. Now, we create a proper temporal range filter based on timestamp and chosen granularity. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://github.com/apache/superset/assets/15073128/47d4a92e-54e6-4ec3-83ae-cc07dacc656f After: https://github.com/apache/superset/assets/15073128/31150ecd-de3e-4c21-9742-fc22febbf8aa ### TESTING INSTRUCTIONS 1. Enable `DRILL_BY` feature flag 2. Add some charts with temporal dimensions to the dashboard 3. Drill by on a temporal series 4. Verify (either by checking the request payload or opening explore) that related adhoc filter is a temporal range filter ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
