john-bodley commented on code in PR #24127:
URL: https://github.com/apache/superset/pull/24127#discussion_r1198478507


##########
superset/views/utils.py:
##########
@@ -261,9 +261,8 @@ def get_datasource_info(
     :raises SupersetException: If the datasource no longer exists
     """
 
-    datasource = form_data.get("datasource", "")
-
-    if "__" in datasource:
+    # pylint: disable=superfluous-parens

Review Comment:
   Sadly we're stuck between a rock and a hard place here. There is a Pylint 
false positive on line #265 but if we add the disable comment there then Black 
will reformat the line  because its > 88 characters and the formatting then 
requires the extra `(...)` per Pylint's rules.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to