mdeshmu commented on PR #24163: URL: https://github.com/apache/superset/pull/24163#issuecomment-1557794041
@john-bodley sorry for inconvenience. Added the summary. There are lots of changes as per https://docs.sqlalchemy.org/en/20/changelog/migration_20.html and keeping compatibility with both sqlalchemy versions is a lot of work and may take time. I gave a shot at fixing imports and ran test cases in PyHive with SQLAlchemy 2.0. Coverage went down to less than 40% due to various depredations in 2.0x I am closing this PR since sqlalchemy 2.0 support might not come to superset until next year. Will revisit in future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
