michael-s-molina commented on code in PR #23870:
URL: https://github.com/apache/superset/pull/23870#discussion_r1202156805
##########
superset/migrations/shared/migrate_viz/processors.py:
##########
@@ -34,20 +34,50 @@ def _pre_action(self) -> None:
class MigrateAreaChart(MigrateViz):
source_viz_type = "area"
target_viz_type = "echarts_area"
+ has_x_axis_control = True
remove_keys = {"contribution", "stacked_style", "x_axis_label"}
+ rename_keys = {
+ "x_axis_label": "x_axis_title",
+ "x_axis_format": "x_axis_time_format",
Review Comment:
I find that weird too. After we migrate the legacy charts and find ourselves
in a more consolidated state, we should have another round to polish the form
data to rename/remove some keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
