villebro opened a new pull request, #24198: URL: https://github.com/apache/superset/pull/24198
### SUMMARY Currently only Admins have "menu access on Security", but despite that, non-admins have "menu access on User's Statistics" which belongs under the "Security" menu (the label for this is "User Registrations"; see the FAB code here: https://github.com/dpgaspar/Flask-AppBuilder/blob/9b3304c366b53a01655c97105691d14efa89a9ba/flask_appbuilder/security/manager.py#L795-L802). This removes menu access ### AFTER After the change, a Gamma user with Alerts & Reports and RLS access will only see the RLS menu under Security:  ### BEFORE Previously, they would also see the User Registrations menu:  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
