zephyring commented on code in PR #24202:
URL: https://github.com/apache/superset/pull/24202#discussion_r1204518195
##########
superset/extensions/ssh.py:
##########
@@ -34,6 +34,7 @@ class SSHManager:
def __init__(self, app: Flask) -> None:
super().__init__()
self.local_bind_address = app.config["SSH_TUNNEL_LOCAL_BIND_ADDRESS"]
+ TUNNEL_TIMEOUT = app.config["SSH_TUNNEL_TIMEOUT"]
Review Comment:
does this set the `TUNNEL_TIMEOUT` constant back to sshtunel? or we still
need to invoke sshtunel. TUNNEL_TIMEOUT = "value"
can we add a test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
