sebastianliebscher commented on code in PR #24213:
URL: https://github.com/apache/superset/pull/24213#discussion_r1205753153


##########
superset/config.py:
##########
@@ -1583,7 +1583,7 @@ class ExtraRelatedQueryFilters(TypedDict, total=False):
     try:
         # pylint: disable=import-error,wildcard-import,unused-wildcard-import
         import superset_config
-        from superset_config import *  # type: ignore
+        from superset_config import *

Review Comment:
   without this, the mypy pre-commit hook blocks the commit. unsure this is the 
appropriate approach



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to